po5 / mpv_sponsorblock

mpv script to skip sponsored segments of YouTube videos
GNU General Public License v3.0
531 stars 29 forks source link

New category - music_offtopic #39

Closed Obegg closed 2 years ago

Obegg commented 2 years ago

https://github.com/ajayyy/SponsorBlock/wiki/Types#category There's a new one that isn't included in this script

music_offtopic

po5 commented 2 years ago

It's already supported, the behavior matches the browser extension (music segments not shown by default). https://github.com/po5/mpv_sponsorblock/blob/29e7b75809107db2bb0c6c6eed0199e063aa75d2/sponsorblock.lua#L108

Obegg commented 2 years ago

It's already supported, the behavior matches the browser extension (music segments not shown by default).

https://github.com/po5/mpv_sponsorblock/blob/29e7b75809107db2bb0c6c6eed0199e063aa75d2/sponsorblock.lua#L108

There are 6 categories here, there are 7 in total. Why doesn't it include the "preview" category too? It should be:

local all_categories = {"sponsor", "intro", "outro", "interaction", "selfpromo", "preview", "music_offtopic"}