search

po5 / mpv_sponsorblock

mpv script to skip sponsored segments of YouTube videos
GNU General Public License v3.0
531 stars 29 forks source link

Folderize mpv_sponsorblock #46

Closed jimman2003 closed 2 years ago

jimman2003 commented 2 years ago
  1. uses a symlink to make mpv autodetect the script
  2. change the script to search within the repo folder
  3. change Readme.md to mention the folder
po5 commented 2 years ago

We lose compatibility for older mpv versions for absolutely no benefit.
Initially to support both versions we had it the other way around, with the script in a folder and a lua file outside of it that would load the main script if an older mpv version was detected.
The current way is much more reliable, works on any version and is unlikely to break anytime soon.
I don't see the point but leaving this open for a bit if you can change my mind.

jimman2003 commented 2 years ago

I just like my scripts folder organized, when I try the current version within a folder in mpv 0.33 I get a warning.... I thought to get rid of that , without thinking about backwards compatability..

po5 commented 2 years ago

You wouldn't get a warning if you didn't remove the file that says... -- do not delete