search

po5 / thumbfast

High-performance on-the-fly thumbnailer script for mpv
Mozilla Public License 2.0
861 stars 35 forks source link

Syncplay bug #100

Closed ymn236 closed 1 year ago

ymn236 commented 1 year ago

This happens when using the script with Syncplay:

2

po5 commented 1 year ago

Are you sure this is a Syncplay issue? It seems very similar to #81, a bug with the MPV-EASY frontend.

Edit: Okay can reproduce with Syncplay and vanilla OSC fork on Linux.

po5 commented 1 year ago

It seems like Syncplay somehow messes with the default ASS alignment, as adding an explicit elem_ass:an(7) to our thumbnail fixes it. I've done that in the above commit, please reopen if you encounter this issue again.

I suspect this is what was happening with MPV-EASY too, thanks for submitting this as it was much easier for me to reproduce and debug.

Et0h commented 1 year ago

Based on this thread I've been able to determine that the issue was that Syncplay in effect ran mpv with --osd-align-y=bottom but thumbfast was only designed to accommodate --osd-align-y=top. I can confirm that the above commit fixes the issue.