po5 / thumbfast

High-performance on-the-fly thumbnailer script for mpv
Mozilla Public License 2.0
758 stars 34 forks source link

Better mpv.net support #109

Open stax76 opened 6 months ago

stax76 commented 6 months ago

You can add this code for better mpv.net support:

local mpvnet_path = mp.get_property_native("user-data/frontend/process-path")
if mpvnet_path then options.mpv_path = mpvnet_path end

@tsl0922 is maybe interested using user-data/frontend/process-path as well. Ideally, mpv would have a process-path util, but implementing it cross-platform is much more complicated.

computator1200 commented 6 months ago

@stax76 could you make a guide on how to use thumbfast with mpv.net

stax76 commented 6 months ago

@computator1200 It's documented here. It requires mpv.net v7.0.0.2. With the suggested code above and mpv.net v7.0.0.2 it would work without any user configuration.

po5 commented 6 months ago

I will implement this but it will have to wait until next time I boot into Windows.

vantiss commented 6 months ago

is implementing this still planned? I've been using mpv.net for a long time now and it would be rad to have this integrated :>

po5 commented 6 months ago

You've been neglecting to read the readme for a while?

vantiss commented 6 months ago

that's the solution I've been using since I learned about thumbfast and it's a great script! I just liked the idea of not needing to do that when I saw this issue pop up a few weeks ago, so I was curious what the status on it was