search

po5 / thumbfast

High-performance on-the-fly thumbnailer script for mpv
Mozilla Public License 2.0
758 stars 34 forks source link

Subtitle bug on mpv 0.38.0, using the forked osc.lua #121

Closed brainwo closed 2 months ago

brainwo commented 2 months ago

Everytime I pause a video or change volume, there are additional copies of subtitle appear on the screen.

https://github.com/po5/thumbfast/assets/45139213/7934e755-a879-47c0-b6ac-7da6eb65edbf

Downgrading to mpv 0.37.0 does remove this problem. Running mpv with --no-config flag also ran without the issue. I have disabled all of my scripts, leaving only osc.lua and thumbfast. The problem is only there when I have these two enabled.

po5 commented 2 months ago

Log file please?

brainwo commented 2 months ago

I tried to reproduce this problem but I'm unable to reproduce this myself. After reinstalling mpv 0.38.0, it seems like the problem is now causes by sub-clear-on-seek option. Now it only triggers whenever sub-clear-on-seek is set to yes. I was enabling this option to see if it helps clearing the subtitle, I didn't enable this prior to having this issue.

And weirdly enough, disabling and enabling osc.lua no longer affect whether or not this problem appears (issue still appears after I switched to the vanilla UI, this wasn't the case before).

I apologize for the trouble. This is no longer a problem for me, I don't remember why I have sub-clear-on-seek set to yes, so I removed it. Thank you for your time replying to this issue.