po5 / thumbfast

High-performance on-the-fly thumbnailer script for mpv
Mozilla Public License 2.0
861 stars 35 forks source link

fix: disable for single frame #14

Closed hooke007 closed 2 years ago

hooke007 commented 2 years ago

work for single frame img only

natural-harmonia-gropius commented 2 years ago

This should be controlled by timeline.

hooke007 commented 2 years ago

For what?

natural-harmonia-gropius commented 2 years ago

The timeline will pass in a legal timestamp and thumbfast should output the thumbnail correctly. If not that garbage in, garbage out.

hooke007 commented 2 years ago

Not agree, let po5 judge it.

natural-harmonia-gropius commented 2 years ago

that so, change to mp.get_property_number("duration", 1) <= 1

hooke007 commented 2 years ago

mp.get_property_number("duration", 1) <= 1

It looks like skipping all the short video rather than only single frame images.

hooke007 commented 2 years ago

close for supporting https://github.com/po5/thumbfast/pull/17