po5 / thumbfast

High-performance on-the-fly thumbnailer script for mpv
Mozilla Public License 2.0
760 stars 34 forks source link

White thumbnails #46

Closed Ashdemai closed 1 year ago

Ashdemai commented 1 year ago

Hi I'm using mpv on a Wayland with GNOME. I have installed your script, but all I get is white thumbnails. Am I missing something? Screenshot from 2022-10-12 07-42-35

po5 commented 1 year ago

Anything in logs when launching mpv through a terminal?
And if you replace line 255 with
"mpv", path, "--no-config", "--idle", "--pause", "--keep-open=always",
(shows logs from the thumbnailer process)

Ashdemai commented 1 year ago

Anything in logs when launching mpv through a terminal? And if you replace line 255 with "mpv", path, "--no-config", "--idle", "--pause", "--keep-open=always", (shows logs from the thumbnailer process)

[mpv_thumbnail_script_client_osc] The 'tracks-changed' event is deprecated and will be removed. (+) Video --vid=1 () (h264 854x480 30.000fps) (+) Audio --aid=1 () (aac 2ch 44100Hz) AO: [pulse] 44100Hz stereo 2ch float VO: [gpu] 854x480 => 854x480 yuv420p AV: 00:00:00 / 00:02:45 (0%) A-V: 0.000 [mpv_thumbnail_script_client_osc] The 'tick' event is deprecated and will be removed. AV: 00:02:40 / 00:02:45 (97%) A-V: -0.000

This is all I get after changing line 255, it remain unchanged.

christoph-heinrich commented 1 year ago

[mpv_thumbnail_script_client_osc] ...

You do know that this script is separate from https://github.com/marzzzello/mpv_thumbnail_script right?

Ashdemai commented 1 year ago

[mpv_thumbnail_script_client_osc] ...

You do know that this script is separate from https://github.com/marzzzello/mpv_thumbnail_script right?

I'm not using that script.

christoph-heinrich commented 1 year ago

I'm not using that script.

Based on that log message you are using it (or the older version https://github.com/TheAMM/mpv_thumbnail_script).

Ashdemai commented 1 year ago

I'm not using that script.

Based on that log message you are using it (or the older version https://github.com/TheAMM/mpv_thumbnail_script).

Anyway even testing in the laptop which doesn't show any errors I still get white thumbnail

Ashdemai commented 1 year ago

I tried doing the same thing I did on a virtual machine and it worked. I have no idea what is the culprit. Is it because I use Nvidia drivers?

po5 commented 1 year ago

hwdec problem? What happens if you remove hwdec from the script on the lines I mentioned above?

Ashdemai commented 1 year ago

I don't know what fixed it, but I redownloaded the thumbfast.lua file and overwritten it with the old one and it fixed the issue.