po5 / thumbfast

High-performance on-the-fly thumbnailer script for mpv
Mozilla Public License 2.0
760 stars 34 forks source link

System cannot find the file specified(mpv.net + uosc) #47

Closed DonBureq closed 1 year ago

DonBureq commented 1 year ago

Hello I have a problem with thumbfast script on Mpv.net(windows) using uosc OSC. The thumbnails are not showing at all and the console is showing "System cannot find the file specified" errors every time i hover cursor over the seek bar. I've checked the regular mpv and both scripts works without problems. I have also tried to run mpv.net with default settings but it didn't help much. Thanks image

dyphire commented 1 year ago

This is because the script only works for mpv, which needs on using mpv commands in subprocesses. https://github.com/po5/thumbfast/blob/eb21b2e871144a328f93c4597cc1932b43783e6a/thumbfast.lua#L253-L255

Unfortunately, mpv.net is based on libmpv(mpv-2.dll), so it cannot use the mpv commands in subprocesses. If you really want to use this script with mpvnet, you have to add mpv to PATH first.

Relevant: https://github.com/mpvnet-player/mpv.net/issues/262, https://github.com/marzzzello/mpv_thumbnail_script/issues/2

DonBureq commented 1 year ago

HI. Thanks for your help. I can confirm that adding mpv to PATH variable fixed the problem. Closing

megapro17 commented 1 year ago

wtf, is running two different player efficient?

po5 commented 1 year ago

If you're asking in the context of mpv.net+regular mpv, it's not any less efficient than the script's normal operation.

If it's the normal operation of running a background instance to generate thumbnails you're asking about, it's a minor memory usage increase over not having the bg instance, with the benefit that generating a new thumbnail is fast (and cheap thanks to your OS's disk access cache).
It's better than the alternative of heavy pre-generating of every thumbnail, and lets us have frame-accurate thumbnails for where you'll end up after seeking.

megapro17 commented 1 year ago

If you're asking in the context of mpv.net+regular mpv, it's not any less efficient than the script's normal operation.

thanks, this is what i wanted to know. i even enabled luajit so i guess it will be more efficent