po5
commented
1 year ago Exact seeks get triggered pretty often when moving over the timeline, especially when the video is unpaused.
This is probably bad for performance.
Could you add something more flexible than the seek_requested boolean? A higher seek_period fixes the issue but makes the whole thumbnail generation slow.
A counter of how many seek_periods have passed, or a delay in seconds, whatever is easier to implement.
I will reintroduce thumb_index and index_time in some form later, as I want to support caching (someone may have an even worse CPU than me) and it will be useful for YouTube support.
christoph-heinrich
The changes from #41 are still relevant, but GitHub didn't let me reopen after I pushed so here is a new one.
Limiting the thumbnail count doesn't make sense when they are generated on the fly, and those limits enables us to do an exact seek after the user stops moving the mouse, allowing them to see the exact frame at the requested time.
Initializing things on startup allows us to simplify
spawn()a bit, after all there is no benefit in checking every time if things need to be initialized.With commands being very fast now, we could even remove the seek throttling. That would allow us to simplify the seeking code.
Seeking without throttling
```diff diff --git a/thumbfast.lua b/thumbfast.lua index 5e97de5..77db9e4 100644 --- a/thumbfast.lua +++ b/thumbfast.lua @@ -396,26 +396,14 @@ local function seek(fast) end local seek_period = 3/60 -local seek_requested = false local seek_timer -seek_timer = mp.add_periodic_timer(seek_period, function() - if seek_requested then - seek_requested = false - seek(true) - else - seek_timer:kill() - seek() - end -end) +seek_timer = mp.add_timeout(seek_period, seek) seek_timer:kill() local function request_seek() - if seek_timer:is_enabled() then - seek_requested = true - else - seek_timer:resume() - seek(true) - end + seek_timer:kill() + seek_timer:resume() + seek(true) end local function check_new_thumb() ```