po5 / thumbfast

High-performance on-the-fly thumbnailer script for mpv
Mozilla Public License 2.0
760 stars 34 forks source link

console msg: mpv subprocess create failed #60

Closed hooke007 closed 1 year ago

hooke007 commented 1 year ago

Once you have checked the current file's thumbnail, it is bound to happen when switching to the next file.

Snipaste_2022-11-01_14-49-23

hooke007 commented 1 year ago

More findings here.

On Windows: It was the first time to be observed by https://github.com/po5/thumbfast/commit/f1ba4a670bb5b90e4260e74b9f8c16d0fbe239e4 , but I am not sure because this commit seems to fix the issue https://github.com/po5/thumbfast/issues/8 . Under the commit https://github.com/po5/thumbfast/commit/6494ae313e6be8655b430997fb0c8ac9952dfabe , the console message was still unreadable for me.

On Mac: Can confirm it was introduced by https://github.com/po5/thumbfast/commit/f1ba4a670bb5b90e4260e74b9f8c16d0fbe239e4 .

po5 commented 1 year ago

I wrote a fix for that before merging #25, but didn't push yet.
The error message is wrong, there is actually no error.

brian6932 commented 1 year ago

I'm still getting this error, although whenever I seek the thumbnail is just blank, it happens whenever I seek, I'm using it with the latest uosc

hooke007 commented 1 year ago

although whenever I seek the thumbnail is just blank

You'd better show more details. Because in my case the msg is fake, no real bugs happened.

brian6932 commented 1 year ago

image Whenever I seek on the seekbar, I get this

hooke007 commented 1 year ago

No, I mean the steps to reproduce or mpv's log.

brian6932 commented 1 year ago

I cloned the repo, symlinked the files to the right portable_config folders Edited the config like this:

# Socket path (leave empty for auto)
socket=

# Thumbnail path (leave empty for auto)
thumbnail=

# Maximum thumbnail size in pixels (scaled down to fit)
# Values are scaled when hidpi is enabled
max_height=200
max_width=200

# Overlay id
overlay_id=42

# Spawn thumbnailer on file load for faster initial thumbnails
spawn_first=yes

# Enable on network playback
network=yes

# Enable on audio playback
audio=no

# Enable hardware decoding
hwdec=yes

# Windows only: use native Windows API to write to pipe (requires LuaJIT)
direct_io=no

Tried default as well, same issue. mpv log: https://i.alienpls.org/LCZ.log Just an example file, occurs on every file, and stream I tested

hooke007 commented 1 year ago

[ 0.011][d][global] config path: '' -> '~\scoop\apps\mpv.net-beta\current\portable_config\'

We have never supported libmpv. Using mpv instead or add the mpv.exe into PATH

brian6932 commented 1 year ago

I'll test it on mpv as well 👍

brian6932 commented 1 year ago

yep that was it, sry for the bother