Open tmpm697 opened 1 year ago
This used to be an option, but it was removed.
Will re-add when YouTube thumbnail fetching is done.
they can see much more frames than 30s.
I’m a little bit confused. Aren’t we already able to see the maximum number of keyframes when surfing on the progress bar? @christoph-heinrich pls correct me if i misunderstand your PR.
Aren’t we already able to see the maximum number of keyframes when surfing on the progress bar?
That is correct. There is currently no limit on the number of thumbnails. I also don't think there is any benefit in limiting it for local files.
Idk but when I try with different type of mkv files (from size and resolutions), even 1080p mkv file, thumbnails still showing lag compare to mouse movement, so I was thought that if we can specify a number of frames that would give more smooth or grain of frames/images --> better user experience.
You could try the previous version which support the limitation of max thumbnails. But I'm afraid it wouldn't improve the slow hardward's rendering problem.
https://github.com/po5/thumbfast/tree/3588fa1dba7351694d46882b1458ae8fd5ee8055
I also don't think it is a good idea to add a limit on the number of thumbnails for local files. It is much better to use keyframe generation for local files currently.
I tried it with:
min_thumbnails=100
max_thumbnails=200
I can see the difference from user perspective, it gives more images at same mouse position, so when you move fast to a location on progress bar, it will give probably 5-10 images as the density of images are now more than default.
You can notice that, the mouse of user would never fixed at a location, because of their hands interact with mouse and its optical sensor, so it always moves around at very tiny area of a location, having setting min/max thumbnails would give user more images to see when they're trying to put at that
location (but actually moving around in a small area of progress bar).
I would probably set to 100-500 min thumbnails per mkv file as I really need more image to get info from what I want to play at.
Please add it back as options.
Update: I really like it and set min to 1000, max 2000 per mkv file, that actually gives smooth feeling when moving mouse around.
But there's a lag, for example: moving really fast to the end of mkv file then moving back really fast too, you'll see images from end of mkv file would appear while moving back mouse at middle of the progress bar. Is this because of io limit of my disk? (I use ssd)
I start to use latest thumbfast, and I don't know if I need to set min/max frame, no idea, it's just fine but should just give that option to user?
I don't find an option for how many frame/images per each 10s for example, so when user
surf
through progress bar they can see much moreframes
than 30s.Can you support this option?