po5 / thumbfast

High-performance on-the-fly thumbnailer script for mpv
Mozilla Public License 2.0
760 stars 34 forks source link

double icon when using osc.lua during player startup #66

Closed AdventurerRussia closed 1 year ago

AdventurerRussia commented 1 year ago

when using the script, one icon hangs over the other. and the smaller the window, the more they diverge

image image image

po5 commented 1 year ago

If you're using the osc.lua fork you'll need to disable the original osc with osc=no in your mpv.conf.
I'll make this more clear in readme. (or disable the original osc automatically like uosc does, I don't know if there are complications from that)

AdventurerRussia commented 1 year ago

If you're using the osc.lua fork you'll need to disable the original osc with osc=no in your mpv.conf. I'll make this more clear in readme. (or disable the original osc automatically like uosc does, I don't know if there are complications from that)

yes, thank you, it's still worth adding some information about it

po5 commented 1 year ago

Does the latest commit to the osc.lua fork fix it for you, without having osc=no in mpv.conf?

AdventurerRussia commented 1 year ago

Does the latest commit to the osc.lua fork fix it for you, without having osc=no in mpv.conf?

I'm sorry I don't understand what it's about, I added osc=no and everything works as it should

po5 commented 1 year ago

Try removing osc=no and re-downloading osc.lua from this link.
Trying to make it work for users out of the box without config changes (:

hooke007 commented 1 year ago

Trying to make it work for users out of the box without config changes (:

No, you also need to add more function to delay-render the fork osc (That's what uosc does). We ever tried this solution and found sometimes it would render before built-in osc. In this case the whole UI would be freezing.

Uosc could work well without osc=no, but you would still see the built-in osc quickily flash when start.

AdventurerRussia commented 1 year ago

Try removing osc=no and re-downloading osc.lua from this link. Trying to make it work for users out of the box without config changes (: osc.lua

image no osc.lua image

AdventurerRussia commented 1 year ago

the icon is deformed when the windows are small but the split icon is gone

hooke007 commented 1 year ago

the icon is deformed when the windows are small

That's because the fork haven't applied the upstream's latest commits.

po5 commented 1 year ago

Incorrectly scaled icon fixed by syncing with upstream.

We ever tried this solution and found sometimes it would render before built-in osc. In this case the whole UI would be freezing.

Not sure that would be an issue here, not knowing what exactly made it freeze with uosc.

you would still see the built-in osc quickily flash when start.

That's fine in our case as it looks the exact same as the original osc. In the worst case, we are flashing two transparent elements on top of each other slightly dimming the UI at launch.

Leaving this open to shoot more ideas.

hooke007 commented 1 year ago

Not sure that would be an issue here, not knowing what exactly made it freeze with uosc.

No, I mean the fork osc would be freezed.

That's fine in our case as it looks the exact same as the original osc.

Only the idle looks perfect but once starting to open the video, the UI disappeared.(Tested by your fork without --osc=no)

https://user-images.githubusercontent.com/41094733/200385355-64cee2f0-681f-41cf-b8f4-1b944ac697dc.mp4

po5 commented 1 year ago

@hooke007 is this fixed in the latest update to the vanilla osc fork?

hooke007 commented 1 year ago

I haven't tried to reproduce it since it's a random issue. Anyway osc=no is necessary since the alt osc script will be tagged as osc2 (if you don't disable osc in mpv.conf), which affects user's keybindings.

Snipaste_2023-04-29_21-49-29

AdventurerRussia commented 1 year ago

is it possible to simply disable this icon? not the interface itself but only the icon

po5 commented 1 year ago

idlescreen script-opt.