po5 / thumbfast

High-performance on-the-fly thumbnailer script for mpv
Mozilla Public License 2.0
758 stars 34 forks source link

Fix spawn_first #76

Closed hooke007 closed 1 year ago

hooke007 commented 1 year ago

https://github.com/po5/thumbfast/issues/74

hooke007 commented 1 year ago

Maybe file-loaded is too early for subprocess to get the enough media info.

N-R-K commented 1 year ago

Maybe file-loaded is too early for subprocess to get the enough media info.

In that case it might fail even after 0.1s as well. I'm not familiar with thumbfast's codebase/internals but is not possible to periodically keep retrying until success?

po5 commented 1 year ago

I think that's been addressed with b913ab503d02b4fd92688bd1977a1b524ad22758 and 19f1122a342f58174e40dba3148e1c2b540a69bb. Janky "fix" anyway.