po5 / thumbfast

High-performance on-the-fly thumbnailer script for mpv
Mozilla Public License 2.0
861 stars 35 forks source link

Unreadable msg shown in console #8

Closed hooke007 closed 1 year ago

hooke007 commented 2 years ago

Snipaste_2022-09-21_10-58-10

Snipaste_2022-09-23_10-38-38

It occurs randomly. (Windows 10 only)

po5 commented 2 years ago

Has anyone been able to reproduce this? Does it happen on specific files?

hooke007 commented 2 years ago

To make it easier to reproduce: set interval = 0 min_thumbnails = 2 and max_thumbnails = 1440 (Larger is better)

Does it happen on specific files?

Almost every video in my device.

I doubt it may be caused some frames, because it is difficult to get this error msg by the small number of thumbnails.

christoph-heinrich commented 2 years ago

Can't reproduce and I also can't find anything in the script that would output anything.

hooke007 commented 2 years ago

Fine, no reproduce in my Mac OS.

hooke007 commented 2 years ago

Another findings here. There must might be some error msg when the preview freezing.

https://user-images.githubusercontent.com/41094733/192055594-87851351-c3fe-4217-a849-1a130d9cba7d.mp4

Tested by https://github.com/po5/thumbfast/commit/85a737ef5b61dc1cd550b9f772ea24a8379bece7 ref https://github.com/po5/thumbfast/issues/11 Also I cannot reproduce freezing with Mac OS. Something else I observed is that the response of preview on Mac is much more smooth and quicker than Windows.

dyphire commented 2 years ago

Can be reproduced on Windows, without specific files.

natural-harmonia-gropius commented 2 years ago

@hooke007 @dyphire Try to enable this. 192082789-fd238ab4-4604-4a7a-b302-5ea826a5e526

I've only seen these two, yet they didn't cause any bugs. 192082822-f2122fd0-ad18-4d59-9819-959c74d0e3bc 191883815-f0b8444f-8c0d-4952-8bd5-2abaaf847164

dyphire commented 2 years ago

@hooke007 @dyphire Try to enable this. 192082789-fd238ab4-4604-4a7a-b302-5ea826a5e526

This is not desirable. Although it can solve the unreadable information of the console, it will also cause issues in more applications.

dyphire commented 2 years ago

Related issue: https://github.com/mpv-player/mpv/issues/10139