Add subcmd `add` - Githubissues

poac-dev / poac

A package manager and build system for C++

https://poac.dev

Apache License 2.0

1.13k stars 73 forks source link

Add subcmd `add` #914

Closed SunPodder closed 7 months ago

SunPodder commented 7 months ago

All fixed including the clang-tidy error

ken-matsui commented 7 months ago

@SunPodder Sorry, there are more clang-tidy errors. Could you please address them? (After that, LGTM)

SunPodder commented 7 months ago

Sorry, it must be annoying for you reviewing the same mistakes. clang-tidy throws errors on my machine even for existing codes which are correct and passes on ci. So it's hard to make sure everything is fine :)

ken-matsui commented 7 months ago

No worries! Which version of clang-tidy are you using?

SunPodder commented 7 months ago

No worries! Which version of clang-tidy are you using?

clang-tidy-15

ken-matsui commented 7 months ago

It seems that clang-tidy-17 fixed the problem, just fyi: https://github.com/llvm/llvm-project/issues/46097.

ken-matsui commented 7 months ago

@SunPodder Can you also update README.md for this command?

SunPodder commented 7 months ago

Sure