Port all tests to the new framework.

poanetwork / hbbft

An implementation of the paper "Honey Badger of BFT Protocols" in Rust. This is a modular library of consensus.

Other

356 stars 96 forks source link

Port all tests to the new framework. #322

Open afck opened 5 years ago

afck commented 5 years ago

We have two integration test frameworks at the moment, in tests/net and tests/network. We need to port all the tests to the former, and remove the latter:

[x] binary_agreement_mitm.rs
[x] binary_agreement.rs
[x] broadcast.rs
[x] honey_badger.rs
[x] net_dynamic_hb.rs
[ ] queueing_honey_badger.rs
[x] subset.rs
[x] threshold_sign.rs
~sync_key_gen.rs (if applicable?)~
~dynamic_honey_badger.rs~

vkomenda commented 5 years ago

I'm not sure why there are two binary_agreement.rs tests in the list. I'll work on porting BA tests.

afck commented 5 years ago

Thanks, I removed the duplicate.

vkomenda commented 5 years ago

I recorded in the checklist that the test of Binary Agreement has been updated in #336.

vkomenda commented 5 years ago

test_threshold_sign_first_silent_50_samples fails sometimes which may indicate a bias but it's currently non-reproducible because it instantiates the RNG with thread_rng instead of using the proptest TestRng. This bug must be fixed as part of this bigger issue.

dforsten commented 5 years ago

test_threshold_sign_first_silent_50_samples is now using TestRng, tolerance increased to 33% as suggested by @vkomenda in the discussions in PR #387.

dforsten commented 5 years ago

sync_key_gen.rs does not use the old network simulator, should probably be taken off the list in this issue.

dforsten commented 5 years ago

dynamic_honey_badger.rs is not present in the test folder any more, should probably be taken off the list in this issue as well.

dforsten commented 5 years ago

PR #389, once merged, will close this issue.