Add a HoneyBadger getter to DynamicHoneyBadger.

poanetwork / hbbft

An implementation of the paper "Honey Badger of BFT Protocols" in Rust. This is a modular library of consensus.

Other

357 stars 96 forks source link

Add a HoneyBadger getter to DynamicHoneyBadger. #381

Closed afck closed 5 years ago

afck commented 5 years ago

It should be possible to get an immutable reference to the HoneyBadger contained in a DynamicHoneyBadger, so properties like received_proposals can be read.

RicoGit commented 5 years ago

Hi! DynamicHoneyBadger has field honey_badget with type HoneyBadger<InternalContrib<C, N>, N> where InternalContrib is private struct. It doesn't allow to create a getter for honey_badger field without making InternalContrib public. Is it okay to make this struct public?

vkomenda commented 5 years ago

Sure. The fields of InternalContrib will remain private anyway.

trendsetter37 commented 5 years ago

Should this issue be closed on account of PR#383?

afck commented 5 years ago

You're right, thanks!