search

poanetwork / hbbft

An implementation of the paper "Honey Badger of BFT Protocols" in Rust. This is a modular library of consensus.
Other
357 stars 96 forks source link

More tests: Honey Badger #401

Open afck opened 5 years ago

afck commented 5 years ago

The HoneyBadger tests currently contain an oddly specific "faulty shares" test: Should that be moved to ThresholdDecrypt tests instead? (See #400.)

Apart from that, we need to ensure that the RandomAdversary doesn't almost exclusively send completely nonsensical messages (e.g. with huge epoch numbers), but uses random distributions that are more likely to uncover bugs.

Let's also evaluate whether additional message ordering strategies would make sense (FIFO, LIFO, different "node speed" distributions)—always with the restriction that all messages must eventually be delivered, of course.

whereistejas commented 3 years ago

Hi @afck and @igorbarinov ! Is this issue still open for someone to work on? If yes, I would love to work on this.

I tried to read through the codebase to look for a solution to solve the second issue regarding RandomAdversary since it looks easier to tackle. If I'm not wrong we need to start at this point: https://github.com/poanetwork/hbbft/blob/d52be00d0e3a1e2872c8d42a076e0dc3cb86b175/hbbft_testing/src/adversary.rs#L553

Please, correct me if I'm wrong.

afck commented 3 years ago

I'm not sure anyone is currently actively maintaining this repository, sorry.