Fix unused error in test and fix markdown format error - Githubissues

poanetwork / hbbft

An implementation of the paper "Honey Badger of BFT Protocols" in Rust. This is a modular library of consensus.

Other

356 stars 96 forks source link

Fix unused error in test and fix markdown format error #414

Closed kigawas closed 5 years ago

kigawas commented 5 years ago

@afck Formated by https://github.com/DavidAnson/vscode-markdownlint

afck commented 5 years ago

Thanks! There are also Node.js and Ruby versions. I made a note for later to consider adding them to CI: https://github.com/poanetwork/hbbft/issues/416

The test failure is due to a security vulnerability found by cargo audit. I'll look into it today…

afck commented 5 years ago

Wait… it actually isn't!

running 1 test
test run_binary_agreement ... FAILED

afck commented 5 years ago

The problem is that your change in sbv_broadcast.rs actually did change behavior: If 2 * self.netinfo.num_faulty() + 1 is equal to self.netinfo.num_faulty() + 1, both branches should be executed, which is why we didn't use an else here.

kigawas commented 5 years ago

Ah, thanks for pointing out. Already fixed.

afck commented 5 years ago

I'm "fixing" CI in #417; please rebase once that's merged. Sorry for the inconvenience!

afck commented 5 years ago

Merged; you can rebase now.