poanetwork / nifty-wallet

A fork of MetaMask focused on the usability of real-world applications
https://chrome.google.com/webstore/detail/nifty-wallet/jbdaocneiiinmjbjlgalhcelgbejmnid
MIT License
92 stars 43 forks source link

(UI Mistake) Copying token's smart contract address instead of wallet's address #410

Closed Figazan closed 3 years ago

Figazan commented 4 years ago

What browser and version did you use?

*Microsoft Edge 84.0.522.58

What operating system did you use?

Windows 10 Home Premium 64 bits

Do you have screenshots showing the problem?

Yes, attached in issue

What is your issue?

There's a critical UI bug where, if not being cautious, can make you copy a token's contract address instead of your wallet's.

If you click on the copy icon:

20200904_195714

or on the 3-dots menu, then the copy address option:

20200904_195826

the user will have copied their wallet address successfully.

However, if they go to the token's 3-dot menu, then the copy address option:

20200904_195853

they will copy the token's smart contract address instead. This has already caused some users to accidentally burn their tokens when attempting to receive them in their wallets, unaware at that moment they just copied the token's contract address instead of their wallet's.

This confusion is entirely avoidable with an updated UI that either moves this option to another part of the wallet less prone to mistakes of this kind, or hides it from this menu. Either way, it should explicitly state it is for copying the token's smart contract address.

vbaranov commented 3 years ago

Action name changed in 5.1.5