search

poanetwork / nifty-wallet

A fork of MetaMask focused on the usability of real-world applications
https://chrome.google.com/webstore/detail/nifty-wallet/jbdaocneiiinmjbjlgalhcelgbejmnid
MIT License
92 stars 42 forks source link

Ethereum.enable promise is not working when app pass-locked #424

Open ilanolkies opened 3 years ago

ilanolkies commented 3 years ago

What browser and version did you use?

Chrome latest

What operating system did you use?

Mac OS

Do you have screenshots showing the problem?

Screen Shot 2020-11-12 at 20 29 45

What is your issue?

In the screenshot I try to show 2 different behaviours that work unexpected:

  1. The wallet does not pop up when sending window.ethereum.enable() when the user has not input their password
  2. When building dapps, the Promise gets resolved with unexpected result. This makes dapps working with Metamask have to handle Nifty login in a different manner. I think this does not make sense and the app should pop up and request pass once the developer triggers enable.
vbaranov commented 3 years ago

Duplicate of https://github.com/poanetwork/nifty-wallet/issues/222

ilanolkies commented 3 years ago

It is mor than just UI. Developers expect that promise not to resolve until the flow is finished.