search

poanetwork / nifty-wallet

A fork of MetaMask focused on the usability of real-world applications
https://chrome.google.com/webstore/detail/nifty-wallet/jbdaocneiiinmjbjlgalhcelgbejmnid
MIT License
92 stars 42 forks source link

ERC-712 support #425

Closed ilanolkies closed 3 years ago

ilanolkies commented 3 years ago

What browser and version did you use?

Chrome latest

What operating system did you use?

Mac OS

Do you have screenshots showing the problem?

Screen Shot 2020-11-12 at 20 21 25

What is your issue?

Nifty does not support ERC-712 (or at least not v4). This is a very important standard for user-facing applications. It moves the user one step forward on understanding what they are signing. Most Ethereum apps are now moving this way to improve user experience on security regards.

Expected behaviour (see domain data on the screen):

Screen Shot 2020-11-12 at 20 22 40

vbaranov commented 3 years ago

Included into 5.2.0. Published.