search

poanetwork / nifty-wallet

A fork of MetaMask focused on the usability of real-world applications
https://chrome.google.com/webstore/detail/nifty-wallet/jbdaocneiiinmjbjlgalhcelgbejmnid
MIT License
93 stars 43 forks source link

MetaMask not recognized by MyEtherWallet and MyCrypto when both Nifty and MetaMask are installed #47

Open andogro opened 6 years ago

andogro commented 6 years ago

When both extensions are enabled and I am logged in to both in the Chrome browser, MEW and MyCrypto default to the Nifty Wallet. If I logout of Nifty but am logged into MetaMask, MEW and MyCrypto do not recognize MetaMask. 2018-07-30_15-43-50

vbaranov commented 6 years ago

It should be noted, that due to https://github.com/poanetwork/metamask-extension/issues/1#issuecomment-405660060 in case of MetaMask and Nifty Wallet both are installed, Nifty Wallet everytime is on top of MetaMask. So, such behaviour will be for all DApps in the current implementation.

@fvictorio @patitonar in continuation of #1, could we also check, if a user is logged in to NW to decide rewrite web3 object or not?

patitonar commented 6 years ago

I think we can check if user is logged in NW before rewriting web3 injected by MetaMask. But the problem is that NW could try to inject web3 before metamask does, so in that case no web3 will be detected. If the user wants to use MetaMask I think the best solution is to disable Nifty Wallet extension.