search

poanetwork / parity-ethereum

Fast, light, robust Ethereum implementation.
https://parity.io
Other
10 stars 12 forks source link

Queue malice reports #107

Closed DemiMarie closed 5 years ago

DemiMarie commented 5 years ago

This is #98, reopened.

DemiMarie commented 5 years ago

@afck How should we test it? What about using #101?

afck commented 5 years ago

Yes, but possibly #101 will have to be extended to test both cases.

DemiMarie commented 5 years ago

We also need to test the case where a node submits a block, even though they are not a validator.

varasev commented 5 years ago

I'm going to test this after I make some high priority tasks (describing the contracts in README, Whitepaper, and commenting contracts' code to help auditors understand the contracts easily - I think it may take 1-2 weeks).

afck commented 5 years ago

I squashed, rebased and added another commit.

varasev commented 5 years ago

Can I start to test this with posdao-test-setup or there are some fixes waiting to be done?

afck commented 5 years ago

Part of this is already in #129. We still need to figure out how to re-enable and fix the part that's commented out in there; but probably this PR should be closed in favor of #129.

varasev commented 5 years ago

We still need to figure out how to re-enable and fix the part that's commented out in there

Do you mean this? https://github.com/poanetwork/parity-ethereum/blob/74fea45aef174a16d31c0e879216fdcd53c07cef/ethcore/src/engines/validator_set/safe_contract.rs#L344-L362

afck commented 5 years ago

Yes, exactly. But I think I already have a solution. Will push it to #129.

varasev commented 5 years ago

Done in #129.