search

poanetwork / parity-ethereum

Fast, light, robust Ethereum implementation.
https://parity.io
Other
10 stars 12 forks source link

Allow specifying stepDuration as a map. #152

Closed afck closed 5 years ago

afck commented 5 years ago

Closes #122, #124, #150.

varasev commented 5 years ago

Should the timestamps be calculated in UTC or in the local time zone?

afck commented 5 years ago

UTC. The timestamps are in Unix time.

varasev commented 5 years ago

If I remove the redundant current_duration, starting_sec, starting_step fields from the Step structure, the unit tests test_counter_increment_too_high and test_counter_duration_remaining_too_high in ethcore/src/engines/authority_round/mod.rs are fine.

afck commented 5 years ago

Sorry! I updated the unit tests.