search

poanetwork / parity-ethereum

Fast, light, robust Ethereum implementation.
https://parity.io
Other
10 stars 12 forks source link

Move blockGasLimitContract to AuRa params and rename it #189

Closed vkomenda closed 5 years ago

vkomenda commented 5 years ago

This is a backport from https://github.com/paritytech/parity-ethereum/pull/10928.

The new name of the parameter is blockGasLimitContractTransitions. @varasev, @phahulin, please use the new name in spec files.

afck commented 5 years ago

@phahulin, @varasev: If I'm reading the code correctly, you also can't specify a single contract address anymore. It has to be a map of block number to contract address.

varasev commented 5 years ago

If I'm reading the code correctly, you also can't specify a single contract address anymore. It has to be a map of block number to contract address.

Yes, we use the map anyway.

varasev commented 5 years ago

I'd propose to merge this after https://github.com/paritytech/parity-ethereum/pull/10928 is finished because there can be other changes as far as I understand.

varasev commented 5 years ago

I'd propose to merge this after paritytech#10928 is finished because there can be other changes as far as I understand.

Ok, let me first test the new aura-pos with the changed param. If that works fine with posdao-test-setup then OK.

varasev commented 5 years ago

That works fine.

afck commented 5 years ago

Sorry for merging early! I think it's pretty independent of the other potential changes in the upstream PR, though.

varasev commented 5 years ago

I think it's pretty independent of the other potential changes in the upstream PR, though.

Yes, it is. I think we will have to add the same changes in our aura-pos when that PR is merged to upstream.