search

poanetwork / poa-dapps-validators

DApp for a list of validators with metadata for POA Network (Core/Sokol). Validators can update metadata using DApp.
https://validators.poa.network
GNU General Public License v3.0
13 stars 41 forks source link

load addresses based on netId #25

Closed rstormsf closed 6 years ago

igorbarinov commented 6 years ago

@rstormsf Let's follow PR police we have in Wizard in other DApps https://github.com/poanetwork/ico-wizard/wiki/Pull-Request-Policy

Quote:

- (Mandatory) Description
   a human-readable description of changes
   a human-readable description of the purpose of the PR
- (Mandatory) What is it: (Fix), (Feature), or (Refactor) in Title, e.g., "(Fix) price of 1 token in Wei > 18 decimals"
- (Mandatory) Developers: Each completed PR should be updated in the Wiki Documentation.
(Recommended) Each PR should have one commit message and therefore should only contain one specific fix or feature. Otherwise, multiple PRs should be made
- (Optional) Any additional concerns or comments
igorbarinov commented 6 years ago

Summarized out PR Policy for DApps in RFC (new format of sharing common policies) Please comment https://github.com/poanetwork/RFC/issues/3 @vbaranov @rstormsf

Btw, @rstormsf let's create an RFC about core/sokol branches modification and policy for all our DApps