Closed ghost closed 6 years ago
@Dobriy-i I can't approve this PR for the following reasons:
It was fork off
https://github.com/poanetwork/poa-dapps-validators/commit/1eb84b960143cff3045ed8e6ff23f7f95f2a3457
this commit which is already old and there are quite a few conflicting changes
Please rebase your work with latest core
branch commit and add a new commit to this PR
Commit missing package-lock.json
file
Provide a description for this PR, example: adding a new nodemon
module. Why?
and advice developers to re-run npm install
Don't commit directly to the main repo, please fork off your own under your own github name and submit PR from your own repo to this repo
@rstormsf i've resolved all conflicts, please check again. About description's question, where should i provide it? here? About fork, let's finish this pull request here, next time i'll work through the fork
@Dobriy-i I've added a description. Next time please use Problem/Solution or List of features approach. Our policy for PRs https://github.com/poanetwork/RFC/issues/3
@igorbarinov i see. @rstormsf i've also added a description to the first post, about nodemon
so up to you next
@Dobriy-i there is bug in header
also @Dobriy-i the color is not chaning in header in Sokol
Fixed indent. The color won't be changed because it is image, if you want we can remove it and use plain color for sokol
@Dobriy-i please remove the image and use plain color
done
Problem: current layout doesn't support responsive layout. Mobile clients see desktop version. Solution: add the responsive layout.
Problem: Default
node sass
compiler compiles two files (index & changed) files Solution: Addnodemon
watcher to watch.scss
files. Do not forgetnpm istall
before using