poanetwork / poa-dapps-validators

DApp for a list of validators with metadata for POA Network (Core/Sokol). Validators can update metadata using DApp.
https://validators.poa.network
GNU General Public License v3.0
13 stars 41 forks source link

Make view responsive #36

Closed ghost closed 6 years ago

ghost commented 6 years ago

Problem: current layout doesn't support responsive layout. Mobile clients see desktop version. Solution: add the responsive layout.

Problem: Default node sass compiler compiles two files (index & changed) files Solution: Add nodemon watcher to watch .scss files. Do not forget npm istall before using

rstormsf commented 6 years ago

@Dobriy-i I can't approve this PR for the following reasons:

  1. It was fork off https://github.com/poanetwork/poa-dapps-validators/commit/1eb84b960143cff3045ed8e6ff23f7f95f2a3457 this commit which is already old and there are quite a few conflicting changes Please rebase your work with latest core branch commit and add a new commit to this PR

  2. Commit missing package-lock.json file

  3. Provide a description for this PR, example: adding a new nodemon module. Why? and advice developers to re-run npm install

  4. Don't commit directly to the main repo, please fork off your own under your own github name and submit PR from your own repo to this repo

ghost commented 6 years ago

@rstormsf i've resolved all conflicts, please check again. About description's question, where should i provide it? here? About fork, let's finish this pull request here, next time i'll work through the fork

igorbarinov commented 6 years ago

@Dobriy-i I've added a description. Next time please use Problem/Solution or List of features approach. Our policy for PRs https://github.com/poanetwork/RFC/issues/3

ghost commented 6 years ago

@igorbarinov i see. @rstormsf i've also added a description to the first post, about nodemon so up to you next

rstormsf commented 6 years ago

@Dobriy-i there is bug in header image

rstormsf commented 6 years ago

also @Dobriy-i the color is not chaning in header in Sokol

ghost commented 6 years ago

Fixed indent. The color won't be changed because it is image, if you want we can remove it and use plain color for sokol

rstormsf commented 6 years ago

@Dobriy-i please remove the image and use plain color

ghost commented 6 years ago

done