(Fix) Don't display MoC for Sokol network if MoC is removed - Githubissues

poanetwork / poa-dapps-validators

DApp for a list of validators with metadata for POA Network (Core/Sokol). Validators can update metadata using DApp.

https://validators.poa.network

GNU General Public License v3.0

13 stars 41 forks source link

(Fix) Don't display MoC for Sokol network if MoC is removed #62

Closed varasev closed 6 years ago

varasev commented 6 years ago

(Mandatory) Description This PR closes small fixes related to https://github.com/poanetwork/poa-dapps-validators/issues/61 and performs npm update web3.
(Mandatory) What is it: (Fix), (Feature) or (Refactor) (Fix)

varasev commented 6 years ago

We could merge it before because the new code checks whether isMasterOfCeremonyRemoved method exists in PoaNetworkConsensus: https://github.com/varasev/poa-dapps-validators/blob/38663f657cb26995ff8aca1946d8ca7f8affd5df/src/contracts/PoaConsensus.contract.js#L21

It has been done to support the current version of PoaNetworkConsensus. This code has been tested with the current PoaNetworkConsensus in Sokol and Core networks.

vbaranov commented 6 years ago

@varasev then let's create for Sokol first

varasev commented 6 years ago

@vbaranov i.e., you suggest adding some code to check whether we are in Sokol in the place where isMasterOfCeremonyRemoved is called, right?

vbaranov commented 6 years ago

yes, if it is not a big change, let's apply changes in this PR only when we are in Sokol. Just to be sure, those changes don't break the functionality and then we will extend it to Core as well.

varasev commented 6 years ago

@vbaranov ok.

varasev commented 6 years ago

I've added checking for Sokol network in the code: https://github.com/poanetwork/poa-dapps-validators/pull/62/commits/81a19e2f331c33b32223422c47c5f858c85a1a64