(Feature) Handle multiple addresses from PoPA

poanetwork / poa-dapps-validators

DApp for a list of validators with metadata for POA Network (Core/Sokol). Validators can update metadata using DApp.

https://validators.poa.network

GNU General Public License v3.0

13 stars 41 forks source link

(Feature) Handle multiple addresses from PoPA #80

Closed unjapones closed 6 years ago

unjapones commented 6 years ago

Issues #75 and #78 render only one address from PoPA on the UI, but the ProoOfPhysicalAddress contract can store multiple confirmed and unconfirmed physical addressed of a given validator. This ticket is meant to cover these scenarios and how the UI should render the data.

Some suggestions:

Render the first (confirmed or unconfirmed) physical address and show a tooltip/accordeon/etc to reveal the extra addresses.
Just a tooltip that states that the validator has multiple addresses, either confirmed or unconfirmed.
A link to the PoPA DApp, although we should add the corresponding feature to the UI of the latter DApp.

varasev commented 6 years ago

@igorbarinov is it enough to show in Validators DApp only the first confirmed address for each validator? What do you think?

igorbarinov commented 6 years ago

Hi guys. I'd like to see all confirmed addresses for a validator. It will bring more transparency into the process.

pablofullana commented 6 years ago

@igorbarinov @varasev what about those addresses that have been registered but not confirmed yet. For example, those for which a validator is waiting for the post card to arrive. Shall we display those as well?

varasev commented 6 years ago

@pablofullana I think we should display them too, but with Unconfirmed label.

varasev commented 6 years ago

This issue seems to be duplicated in https://github.com/poanetwork/poa-dapps-validators/issues/78. Maybe close this one and continue the discussion there?