search

poanetwork / poa-dapps-voting

POA Network Governance Dapp
https://voting.poa.network
GNU General Public License v3.0
26 stars 54 forks source link

(Feature) Supplement "Add Mining Key" by extra fields to allow adding three keys at once #131

Closed varasev closed 6 years ago

varasev commented 6 years ago

Problem: now VotingToChangeKeys smart contract allows to create ballot to add new validator by adding three keys at once (mining/voting/payout), but the web interface of Voting DApp doesn't allow to use this feature yet.

Solution: add an ability to create three validator's keys at once to the web interface of Voting DApp.

This issue is related to https://github.com/poanetwork/poa-dapps-voting/issues/83 and https://github.com/poanetwork/poa-network-consensus-contracts/issues/92.

varasev commented 6 years ago

I've added extra fields for creating a new validator in https://github.com/varasev/poa-dapps-voting/commit/661beb1ba48d74fe9fa89db37cf39055aa6e3fd4.

This hasn't been tested yet with the new contracts, but web interface works fine. Now it looks like this:

screen

varasev commented 6 years ago

This is how a ballot card looks:

image

varasev commented 6 years ago

Commits with the changes described above:

https://github.com/varasev/poa-dapps-voting/commit/661beb1ba48d74fe9fa89db37cf39055aa6e3fd4 https://github.com/varasev/poa-dapps-voting/commit/429593299eae9e2f3b729ba39840bc0bcc02da57 https://github.com/varasev/poa-dapps-voting/commit/944db87184227d90df0a05b5a2d39d7f448392f3 https://github.com/varasev/poa-dapps-voting/commit/8da49125a025f14a88a558ca1dc78df4a7ef9b77 https://github.com/varasev/poa-dapps-voting/commit/d075d8a43cd962609ffefcfc01b598ca6ecc5687

The corresponding PR will be created after security audit of smart contracts is done.

varasev commented 6 years ago

Done in #134.