varasev
commented
6 years ago It seems that contract methods execution handler could be implemented as a separate function
@vbaranov yes, but in the next PR #146 these functions have different implementations, so I suggest to leave them as they are:
- https://github.com/varasev/poa-dapps-voting/blob/d52d5f59157ab4820607920dc0059977a86a34fb/src/components/BallotCard.jsx#L187-L211
- https://github.com/varasev/poa-dapps-voting/blob/d52d5f59157ab4820607920dc0059977a86a34fb/src/components/BallotCard.jsx#L253-L265
metamask -> Metamask Let's remove
.then((result) => {})
Ok, I fixed these in https://github.com/poanetwork/poa-dapps-voting/pull/146 (commit https://github.com/poanetwork/poa-dapps-voting/pull/146/commits/d52d5f59157ab4820607920dc0059977a86a34fb) as it covers all changes from this #145 PR.
(Mandatory) Description Transaction status is not checked when voting for a ballot or a ballot finalizing. Relates to https://github.com/poanetwork/poa-dapps-voting/issues/123 and https://github.com/poanetwork/poa-dapps-voting/issues/144.
(Mandatory) What is it: (Fix), (Feature) or (Refactor) (Fix)