Closed gabitoesmiapodo closed 6 years ago
Looks great!
@vbaranov for some reason the current version has the font size for those elements set to zero (I thought that it was on purpose).
I think we could do something like this to differentiate or at least separate the items, to make them easier to read:
Using too many colors could potentially be visually noisy, and we already have three colors there, excluding white / black / gray.
@gabitoesmiapodo ok, vertical lines look good for separation.
@gabitoesmiapodo
for some reason the current version has the font size for those elements set to zero (I thought that it was on purpose).
and, no. It was unintentional. Let's fix it.
@gabitoesmiapodo please also note, that "Key type" column may have a long line like "mining, voting, payout". The same thing with "Affected key" column. Example: https://github.com/poanetwork/poa-dapps-voting/issues/131#issuecomment-396251309 - in that case, "Validator key" column must be hidden.
@vbaranov implemented the visual changes:
@varasev noted. I only made some changes to the CSS here, so the logic should work as before.
@gabitoesmiapodo could you merge upstream/core
branch into your restyling
branch?
Some style changes
@gabitoesmiapodo as we already merged this PR, could you create a new one to satisfy these changes ☝️?
Those styles look much better ☝️
@varasev @vbaranov sorry for the delay. I'm currently working on some other things, but this will be done.
Maybe we should create an issue so this doesn't get lost?
May be we should create an issue so this doesn't get lost?
@gabitoesmiapodo Yes, create, please.
@gabitoesmiapodo Thanks!
- Description:
Facelift for the Governance DApp.
There were no designs provided, so the restyling had to be done taking the POA Network Bridge UI and the POA Network style guide as guidelines.
- What is it: Feature
What to expect visually from this update: