Closed varasev closed 6 years ago
(Mandatory) Description The current VotingToChangeKey contract allows creating a ballot for adding voting or payout key with 0x0 mining key (see VotingToChangeKey.areBallotParamsValid function: https://github.com/poanetwork/poa-network-consensus-contracts/blob/aa45e19ca50f7cae308c1281d950245b0c65182a/contracts/VotingToChangeKeys.sol#L252). Corresponding issue: https://github.com/poanetwork/poa-dapps-voting/issues/161. This will be fixed in the new contract but for now I propose adding the checking for zero mining key in the code of Voting DApp.
VotingToChangeKey
VotingToChangeKey.areBallotParamsValid
(Mandatory) What is it: (Fix), (Feature), or (Refactor) (Fix)
(Mandatory) Description The current
VotingToChangeKey
contract allows creating a ballot for adding voting or payout key with 0x0 mining key (seeVotingToChangeKey.areBallotParamsValid
function: https://github.com/poanetwork/poa-network-consensus-contracts/blob/aa45e19ca50f7cae308c1281d950245b0c65182a/contracts/VotingToChangeKeys.sol#L252). Corresponding issue: https://github.com/poanetwork/poa-dapps-voting/issues/161. This will be fixed in the new contract but for now I propose adding the checking for zero mining key in the code of Voting DApp.(Mandatory) What is it: (Fix), (Feature), or (Refactor) (Fix)