(Fix) Finalization w/o reverts, some optimizations and refactoring - Githubissues

poanetwork / poa-dapps-voting

POA Network Governance Dapp

https://voting.poa.network

GNU General Public License v3.0

26 stars 54 forks source link

(Fix) Finalization w/o reverts, some optimizations and refactoring #165

Closed varasev closed 6 years ago

varasev commented 6 years ago

(Mandatory) Description

These are corresponding changes for https://github.com/poanetwork/poa-network-consensus-contracts/pull/155. They are backward compatible and can be merged right now.

Ballot finalization now checks for BallotFinalized event emitting.
getBallotLimitPerValidator and areBallotParamsValid functions are now called from BallotsStorage contract.
getMiningByVotingKey function is now called from KeysManager contract.

(Mandatory) What is it: (Fix), (Feature), or (Refactor) (Fix)