(Refactor) Put address arguments at the end of argument list of functions

poanetwork / poa-dapps-voting

POA Network Governance Dapp

https://voting.poa.network

GNU General Public License v3.0

26 stars 54 forks source link

(Refactor) Put address arguments at the end of argument list of functions #172

Closed varasev closed 5 years ago

varasev commented 6 years ago

(Mandatory) Description These are changes related to https://github.com/poanetwork/poa-network-consensus-contracts/pull/178.
(Mandatory) What is it: (Fix), (Feature), or (Refactor) (Refactor)

varasev commented 6 years ago

@vbaranov This is because we cannot change the order of args in createVotingForKeys and createBallotToChangeProxyAddress functions due to old smart contracts are deployed.

createBallot is used in case of new upgradable smart contracts and has another order of args. The reason of changing the order for new contracts is described in https://github.com/poanetwork/poa-network-consensus-contracts/pull/178 (to limit the risk of short address attack).

varasev commented 5 years ago

@vbaranov I left my comment above. Is everything ok? Could we merge it now?