(Fix) Display alert on clicking `New Ballot` button if MetaMask is locked

poanetwork / poa-dapps-voting

POA Network Governance Dapp

https://voting.poa.network

GNU General Public License v3.0

26 stars 54 forks source link

Closed varasev closed 5 years ago

varasev commented 5 years ago

(Mandatory) Description Solves https://github.com/poanetwork/poa-dapps-voting/issues/156. Now, DApp will display the alert You haven't chosen any account in MetaMask... on clicking New Ballot button if MetaMask is locked. Also, this PR refactors some code defining netId for different networks. Should be merged after https://github.com/poanetwork/poa-dapps-voting/pull/176 is merged.
(Mandatory) What is it: (Fix), (Feature), or (Refactor) (Fix)

varasev commented 5 years ago

@vbaranov Done. This PR does the next things:

modifies onNewBallotRender function: https://github.com/poanetwork/poa-dapps-voting/pull/177/files#diff-14b1e33d5bf5649597cdc0e4f684daddR70
refactors the code added in the previous PR #176 (constants instead of hardcoded values of netId)
adds isTestnet function into helpers.js