(Feature) New style for xDai network

poanetwork / poa-dapps-voting

POA Network Governance Dapp

https://voting.poa.network

GNU General Public License v3.0

26 stars 54 forks source link

(Feature) New style for xDai network #192

Closed gabitoesmiapodo closed 5 years ago

gabitoesmiapodo commented 5 years ago

Closes #187

Description: Updated the dApp to make it able to support different styles, colors, etc. for different networks.

Fixed a few styling and layout issues here and there.

Added some standard components taken from other POA Network dApps, in hopes to have a more coherent and consistent ecosystem.

Hopefully improved responsive versions.

What is it: Update / new feature.

Additional Info: I'm attaching a few screen captures to know what to expect from this update.

Ballots section

localhost_3000_poa-dapps-voting laptop with mdpi screen

New Ballot section

localhost_3000_poa-dapps-voting_new laptop with mdpi screen

Mobile menu

localhost_3000_poa-dapps-voting_new nexus 6p 1

Loading component

localhost_3000_poa-dapps-voting_new laptop with mdpi screen

gabitoesmiapodo commented 5 years ago

@vbaranov

Footer logo should be clickable -> Fixed.
Should be bolder... -> Fixed.
New / "New Ballot" title -> Fixed.
Only first letter should be capitalized -> Fixed.
First letters should be capitalized -> Fixed.
Wrong icon order. -> Fixed.

varasev commented 5 years ago

Please don't merge this yet. I'll review as well.

gabitoesmiapodo commented 5 years ago

@varasev

Sure, no problem.

varasev commented 5 years ago

2) When I click on New Ballot, I see the loading screen for a few seconds. On the previous version of DApp, there is no loading screen when clicking on New Ballot. Is there something new being loaded now?

It seems the reason is that New Ballot button is not NavLink. Please make it use NavLink as other navigation links use (All, Active, and To Finalize).

gabitoesmiapodo commented 5 years ago

@varasev

Let's automatically scroll the page up when we click on All, Active, or To Finalize. -> Done.
When I click on New Ballot, I see the loading screen for a few seconds. On the previous version of DApp, there is no loading screen when clicking on New Ballot. Is there something new being loaded now? It seems the reason is that New Ballot button is not NavLink. Please make it use NavLink as other navigation links use (All, Active, and To Finalize). -> Yes, you are right. Exchanged the link element for a NavLink. I did that too for the header and footer's logos, so everything should be smooth now.
Long description of a ballot isn't fully displayed on small screens (I used Chrome's responsive mode to discover it). -> Fixed.