search

poanetwork / poa-dapps-voting

POA Network Governance Dapp
https://voting.poa.network
GNU General Public License v3.0
26 stars 54 forks source link

(bug) Incorrect ballot results for minimum value #208

Closed rstormsf closed 4 years ago

rstormsf commented 4 years ago

The UI voting dapp shows incorrect value for minimum number of validators that was required to vote. Example: image

it shows as 5, while it was actually 8 during the ballot.

varasev commented 4 years ago

Yes, the DApp displays the current minThreshold value for all the ballots and doesn't use VotingTo*.getMinThresholdOfVoters individual getter for each separate ballot. That should be fixed.

varasev commented 4 years ago

Done in https://github.com/poanetwork/poa-dapps-voting/pull/214. Please note, that we had to remove displaying the total number of validators in the ballot since it was incorrect (that was displaying the current total number of validators, not the number actual at the moment of ballot's finalization - the actual number for each ballot is not stored anywhere in the contracts), so now the ballot looks like this:\ \ image