search

poanetwork / poa-network-consensus-contracts

Main repository for POADAO consensus. Includes contracts for Initial Ceremony, Governance, Management of Validators
GNU General Public License v3.0
68 stars 64 forks source link

Introduce min ballot duration in VotingToManageEmissionFunds contract #207

Closed maxaleks closed 5 years ago

maxaleks commented 5 years ago

https://github.com/poanetwork/poa-network-consensus-contracts/issues/190

varasev commented 5 years ago

Let's also add canBeFinalizedNow into this condition: https://github.com/poanetwork/poa-network-consensus-contracts/blob/f7a374573200e5b002338036cc17f4fb2ec85d14/contracts/VotingToManageEmissionFunds.sol#L223 and add an additional unit tests to test/voting_to_manage_emission_funds_*.js for the VotingToManageEmissionFunds.finalize, vote, and init functions to cover the added code by tests.

varasev commented 5 years ago

I've checked the changes with poa-test-setup and found no problems, so I'm approving this PR.