poanetwork / poa-poba

DApp for proof of bank account (PoBA) attestation
GNU General Public License v3.0
3 stars 6 forks source link

Register bank account data #43 #45

Closed garatortiz closed 6 years ago

garatortiz commented 6 years ago

Closes #43

Register basic bank account data.

garatortiz commented 6 years ago

@fvictorio Can you review in the smart-contracts the struct and the register method?

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 103


Changes Missing Coverage Covered Lines Changed/Added Lines %
server/controllers/accounts.js 12 14 85.71%
<!-- Total: 15 17 88.24% -->
Totals Coverage Status
Change from base Build 100: -0.2%
Covered Lines: 84
Relevant Lines: 100

💛 - Coveralls
fvictorio commented 6 years ago

It looks good, except for a detail I left a comment about. I only looked at the solidity code.