Improve error handling in frontend

poanetwork / poa-poba

DApp for proof of bank account (PoBA) attestation

GNU General Public License v3.0

3 stars 6 forks source link

Improve error handling in frontend #60

Closed garatortiz closed 6 years ago

garatortiz commented 6 years ago

Closes #36

garatortiz commented 6 years ago

@fvictorio @phahulin Please, if you can review it, and comment if you have any ideas.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 158

0 of 4 (0.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.5%) to 54.441%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
frontend/src/alerts.js	0	1	0.0%
frontend/src/PoBA.js	0	3	0.0%
<!--	Total:	0	4	0.0%	-->

Totals
Change from base Build 151:	-0.5%
Covered Lines:	162
Relevant Lines:	266

💛 - Coveralls

fvictorio commented 6 years ago

We should also emit a proper error if the contract is not deployed in the current network. I think this error will be thrown by the PobaContract.deployed() function.