(Improvement) Remove Plaid token from URL - Githubissues

poanetwork / poa-poba

DApp for proof of bank account (PoBA) attestation

GNU General Public License v3.0

3 stars 6 forks source link

(Improvement) Remove Plaid token from URL #84

Closed unjapones closed 6 years ago

unjapones commented 6 years ago

Closes #82 .

Remove Plaid's token from URL after the authentication step (Plaid's plugin): this prevent unintended Plaid info access for an accidental URL share.
Store the token in localStorage to make the Plaid's bank accounts page more user friendly after a browser refresh.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 235

16 of 25 (64.0%) changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.7%) to 82.526%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
frontend/src/ui/context/PlaidContext.js	7	8	87.5%
frontend/src/App.js	1	3	33.33%
frontend/src/ui/containers/PlaidButton.js	5	8	62.5%
frontend/src/ui/pages/MyPlaidBankAccountsPage.js	3	6	50.0%
<!--	Total:	16	25	64.0%	-->

Totals
Change from base Build 234:	-0.7%
Covered Lines:	334
Relevant Lines:	408

💛 - Coveralls

unjapones commented 6 years ago

Closed this in favor of #85