poanetwork / poa-poba

DApp for proof of bank account (PoBA) attestation
GNU General Public License v3.0
3 stars 6 forks source link

(Feature) Add ERC-725/ERC-735 implementation #86

Closed unjapones closed 5 years ago

unjapones commented 5 years ago

Closes #83 .

The following GIF shows the UI interaction: addclaimtoidentity

The branch unjapones/poa-poba/tree/add-erc735-generation-page_with-user-identity-contract that allows the full testing of the code as it is done in the GIF above and in this screencast: https://drive.google.com/file/d/1CTRd516zVOvl9wi2gA8zoZbFM1Tl_zkW/view?usp=sharing

Notes

This PR is similar to another one found in poa-popa, with some considerations

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 238


Changes Missing Coverage Covered Lines Changed/Added Lines %
frontend/src/App.js 0 1 0.0%
frontend/src/ui/containers/PlaidBankAccounts.js 0 1 0.0%
frontend/src/PoBAServer.js 1 3 33.33%
frontend/src/ui/containers/AddClaimToIdentityContractButton.js 19 21 90.48%
frontend/src/ui/containers/GenerateErc735ClaimForm.js 27 29 93.1%
frontend/src/ui/pages/AddClaimToIdentityPage.js 15 18 83.33%
frontend/src/ui/utils/erc725.js 6 10 60.0%
blockchain/contracts/KeyHolder.sol 28 50 56.0%
<!-- Total: 144 181 79.56% -->
Files with Coverage Reduction New Missed Lines %
frontend/src/PoBAServer.js 1 21.43%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 237: -2.8%
Covered Lines: 469
Relevant Lines: 573

💛 - Coveralls