Closed unjapones closed 5 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
frontend/src/App.js | 0 | 1 | 0.0% | ||
frontend/src/ui/containers/PlaidBankAccounts.js | 0 | 1 | 0.0% | ||
frontend/src/PoBAServer.js | 1 | 3 | 33.33% | ||
frontend/src/ui/containers/AddClaimToIdentityContractButton.js | 19 | 21 | 90.48% | ||
frontend/src/ui/containers/GenerateErc735ClaimForm.js | 27 | 29 | 93.1% | ||
frontend/src/ui/pages/AddClaimToIdentityPage.js | 15 | 18 | 83.33% | ||
frontend/src/ui/utils/erc725.js | 6 | 10 | 60.0% | ||
blockchain/contracts/KeyHolder.sol | 28 | 50 | 56.0% | ||
<!-- | Total: | 144 | 181 | 79.56% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
frontend/src/PoBAServer.js | 1 | 21.43% | ||
<!-- | Total: | 1 | --> |
Totals | |
---|---|
Change from base Build 237: | -2.8% |
Covered Lines: | 469 |
Relevant Lines: | 573 |
Closes #83 .
The following GIF shows the UI interaction:
The branch
unjapones/poa-poba/tree/add-erc735-generation-page_with-user-identity-contract
that allows the full testing of the code as it is done in the GIF above and in this screencast: https://drive.google.com/file/d/1CTRd516zVOvl9wi2gA8zoZbFM1Tl_zkW/view?usp=sharingNotes
This PR is similar to another one found in
poa-popa
, with some considerationsPoBA.sol
contract (there was an issue inpoa-popa
that didn't allowed this.)