poanetwork / poa-popa

DApp for proof of physical address (PoPA) attestation for validators of POA Network
https://popa.poa.network
GNU General Public License v3.0
24 stars 18 forks source link

(Feature) Show list of registeded addresses #101

Closed garatortiz closed 6 years ago

garatortiz commented 6 years ago

Depends on #100.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 298


Changes Missing Coverage Covered Lines Changed/Added Lines %
web-dapp/src/components/App.js 0 1 0.0%
web-dapp/src/components/MyAddressesPage.js 2 48 4.17%
<!-- Total: 16 63 25.4% -->
Totals Coverage Status
Change from base Build 280: -1.2%
Covered Lines: 830
Relevant Lines: 1109

💛 - Coveralls
fvictorio commented 6 years ago

@Janther I added an unregisterAddress method to the PoPA contract for the feature of removing registered addresses. Please take a look at it and tell me if you think that approach will work.

garatortiz commented 6 years ago

image

fvictorio commented 6 years ago

This is in a stable point right now, I think we can merge it and do the pending things (improving the styles and whatever issue we find later) in separate PRs.

phahulin commented 6 years ago

After #95 popa.userAddressesCount should be changed to popa.userSubmittedAddressesCount

fvictorio commented 6 years ago

After #95 popa.userAddressesCount should be changed to popa.userSubmittedAddressesCount

Fixed, thanks.