poanetwork / poa-popa

DApp for proof of physical address (PoPA) attestation for validators of POA Network
https://popa.poa.network
GNU General Public License v3.0
24 stars 18 forks source link

(Refactor) some variable declarations were be avoided. Readability and gas costs were improved #117

Closed Janther closed 6 years ago

Janther commented 6 years ago

Cleaning up the code before having it in production.

Refactor of a decreasing for statement. Removal of a variable declaration that was only used once in unregisterAddress().

Also, some standardization in some statements was performed.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 369


Changes Missing Coverage Covered Lines Changed/Added Lines %
blockchain/contracts/ProofOfPhysicalAddress.sol 4 11 36.36%
<!-- Total: 4 11 36.36% -->
Files with Coverage Reduction New Missed Lines %
blockchain/contracts/ProofOfPhysicalAddress.sol 1 47.03%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 366: 0.05%
Covered Lines: 875
Relevant Lines: 1128

💛 - Coveralls