Event log is beneficial to the observation of setting variables

poanetwork / poa-popa

DApp for proof of physical address (PoPA) attestation for validators of POA Network

https://popa.poa.network

GNU General Public License v3.0

24 stars 18 forks source link

Event log is beneficial to the observation of setting variables #125

Closed pablofullana closed 6 years ago

pablofullana commented 6 years ago

Observation: When calling setSigner() with a new signer address, it is highly recommended that you emit an event to log the execution. This is not standard behavior, though it helps you track the history and lets you notice the variable has been changed. Similar functions are listed below: setRegistry(), registerAddress(), unregisterAddress()

phahulin commented 6 years ago

Let's also add an event for confirmAddress(). @pablofullana what do you think? Then we'll have a complete lifecycle reflected in events

pablofullana commented 6 years ago

Indeed, sounds logical to have that one as well. @fvictorio any thoughts against this?

fvictorio commented 6 years ago

No, that makes sense :+1: