poanetwork / poa-popa

DApp for proof of physical address (PoPA) attestation for validators of POA Network
https://popa.poa.network
GNU General Public License v3.0
24 stars 18 forks source link

Apply new graphic design #139

Closed garatortiz closed 6 years ago

garatortiz commented 6 years ago

Closes #141

Note: Frontend tests are failing.

fvictorio commented 6 years ago

Things I noticed:

fernandomg commented 6 years ago

Small details I've found so far:

garatortiz commented 6 years ago

To make the question marks work, we need add this code. How can I add this code in the React view?

 $(".info").hover(
          function () {
            $(this).find('.hidden-info').fadeOut();
            $(this).find('.hidden-info').fadeIn();

          },
          function () {
            $(this).find('.hidden-info').fadeIn();
            $(this).find('.hidden-info').fadeOut();
          }
        )
garatortiz commented 6 years ago

@fvictorio @fernandomg it's ready to review

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 474


Changes Missing Coverage Covered Lines Changed/Added Lines %
web-dapp/src/components/MyAddressesPage.js 1 2 50.0%
web-dapp/src/components/HelpPage.js 0 1 0.0%
web-dapp/src/components/App.js 2 5 40.0%
<!-- Total: 6 11 54.55% -->
Totals Coverage Status
Change from base Build 470: 0.7%
Covered Lines: 974
Relevant Lines: 1189

💛 - Coveralls
phahulin commented 6 years ago

Few more things I noticed. Let me know if those are out of scope of this PR, and will go to a different PRs:

  1. page icon (on chrome tab) is from the previous version (eye in triangle)
  2. "How it works" button doesn't work (if I click on it - nothing happens)
  3. when opening "My addresses" page, the image on the left side of the page scales up
  4. postcards are still in the previous version of design
  5. there is margin on top of each page. On some pages (/register, /confirm) this leads to emergence of vertical scroll bar, maybe remove them if possible selection-2018-05-29-01 38 10-001
  6. on "my addresses" page footer "2018 POA..." goes up to the middle of the page (depending on the amount of addresses in the list)
  7. "register new address" page leads to /register route, which is not declared in web-dapp/app.js https://github.com/poanetwork/poa-popa/blob/master/web-dapp/app.js#L13-L15 https://github.com/poanetwork/poa-popa/blob/master/web-dapp/app.js#L22-L23 if you copy url and paste it in incognito mode you get "Cannot GET /register" 404 error
garatortiz commented 6 years ago

@phahulin done!

phahulin commented 6 years ago

Postcard templates are mixed up - back and front covers should be swaped