Closed garatortiz closed 6 years ago
Things I noticed:
Small details I've found so far:
?confirmationCodePlain=
added to the URL. If I click on the arrow button, everything works fine.https://medium.com/poa-network
320px
and 1300px
, Proof of Physical Address legend in logo looks like a serif-like fontTo make the question marks work, we need add this code. How can I add this code in the React view?
$(".info").hover(
function () {
$(this).find('.hidden-info').fadeOut();
$(this).find('.hidden-info').fadeIn();
},
function () {
$(this).find('.hidden-info').fadeIn();
$(this).find('.hidden-info').fadeOut();
}
)
@fvictorio @fernandomg it's ready to review
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
web-dapp/src/components/MyAddressesPage.js | 1 | 2 | 50.0% | ||
web-dapp/src/components/HelpPage.js | 0 | 1 | 0.0% | ||
web-dapp/src/components/App.js | 2 | 5 | 40.0% | ||
<!-- | Total: | 6 | 11 | 54.55% | --> |
Totals | |
---|---|
Change from base Build 470: | 0.7% |
Covered Lines: | 974 |
Relevant Lines: | 1189 |
Few more things I noticed. Let me know if those are out of scope of this PR, and will go to a different PRs:
/register
, /confirm
) this leads to emergence of vertical scroll bar, maybe remove them if possible
web-dapp/app.js
https://github.com/poanetwork/poa-popa/blob/master/web-dapp/app.js#L13-L15
https://github.com/poanetwork/poa-popa/blob/master/web-dapp/app.js#L22-L23
if you copy url and paste it in incognito mode you get "Cannot GET /register" 404 error@phahulin done!
Postcard templates are mixed up - back and front covers should be swaped
Closes #141
Note: Frontend tests are failing.