Closed phahulin closed 6 years ago
(Refactor)
https://github.com/poanetwork/poa-popa/blob/master/blockchain/contracts/ProofOfPhysicalAddress.sol#L123 this condition should (almost) never be true, it's much more likely that keccakIdentifier == 0x0 because of some logical error in code, so it's recommended to replace conditional if (...) { return false } with assertion
keccakIdentifier == 0x0
if (...) { return false }
assert(keccakIdentifier != 0x0)
(Refactor)proposal (i.e. no new features or updates, just code optimization/library updates)https://github.com/poanetwork/poa-popa/blob/master/blockchain/contracts/ProofOfPhysicalAddress.sol#L123 this condition should (almost) never be true, it's much more likely that
keccakIdentifier == 0x0because of some logical error in code, so it's recommended to replace conditionalif (...) { return false }with assertion