poanetwork / poa-popa

DApp for proof of physical address (PoPA) attestation for validators of POA Network
https://popa.poa.network
GNU General Public License v3.0
24 stars 18 forks source link

(Improvement) Revist UI texts #153

Closed garatortiz closed 6 years ago

garatortiz commented 6 years ago

Before submitting a pull request, please provide the following information:

Please also put it into pull request title, e.g. (Fix) confirmation page loading

image

image

image

image

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 472


Changes Missing Coverage Covered Lines Changed/Added Lines %
web-dapp/src/components/MyAddressesPage.js 1 2 50.0%
web-dapp/src/components/HelpPage.js 0 1 0.0%
web-dapp/src/components/App.js 2 5 40.0%
<!-- Total: 6 11 54.55% -->
Totals Coverage Status
Change from base Build 470: 0.7%
Covered Lines: 974
Relevant Lines: 1189

💛 - Coveralls
phahulin commented 6 years ago
fvictorio commented 6 years ago

Something related to the previous PR but that I hadn't noticed: the "Back" button reloads the page instead of just changing the route. The fix is easy: change <a href="/"> to <Link to="/">, but that breaks the tests and fixing them is not straightforward.

If you agree with this, I will create an issue with more information.