Closed garatortiz closed 6 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
web-dapp/src/components/MyAddressesPage.js | 1 | 2 | 50.0% | ||
web-dapp/src/components/HelpPage.js | 0 | 1 | 0.0% | ||
web-dapp/src/components/App.js | 2 | 5 | 40.0% | ||
<!-- | Total: | 6 | 11 | 54.55% | --> |
Totals | |
---|---|
Change from base Build 470: | 0.7% |
Covered Lines: | 974 |
Relevant Lines: | 1189 |
Something related to the previous PR but that I hadn't noticed: the "Back" button reloads the page instead of just changing the route. The fix is easy: change <a href="/">
to <Link to="/">
, but that breaks the tests and fixing them is not straightforward.
If you agree with this, I will create an issue with more information.
Before submitting a pull request, please provide the following information:
(Improvement)
of existing functionalityPlease also put it into pull request title, e.g.
(Fix) confirmation page loading
What was the root cause of the problem originally / what feature was missing?
How does this pull request solve it (in broad terms)? The texts proposed here are only to give an idea of the information that could be provided, and some small changes in their location. Surely all texts need to be reviewed by a
copywriter
and some sections, 'how it works' for example, require work by the designer.Does it close any open issues? Closes #140
Quick checklist
npm run lint
shows no errorsAdditional information